Skip to content

Filter by tag proposals #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
May 21, 2025
Merged

Filter by tag proposals #503

merged 49 commits into from
May 21, 2025

Conversation

segir187
Copy link
Contributor

@segir187 segir187 commented Apr 8, 2025

Closes #420. Closes #487.

Make it possible to search by algorithm tag proposals.

Includes wording change for the checkbox controlling tag proposals so Transifex will need to be updated if the change is kept.

segir187 added 13 commits April 2, 2025 16:55
@segir187
Add 'include_proposals_in_search_results' to context for problem-list…
acd3c8d 
….html.
@segir187
Split prefetch_tags into prefetch_tags and prefetch_top_tag_proposals.
7369d02
@segir187
search_problems_in_query -> filter_problems_by_query, prefetch_top_ta…
4fa6fb4 
…g_proposals before filtering by query
@segir187
Initial implementation of filtering by top_tag_proposals.
ceccba3
@segir187
Fix wrong import source for settings.
758ea19
@segir187
Fix prefetching top_tag_proposals.
f6c0768
@segir187
Fix filter_problems_by_query - it now returns the modified set.
7bf2340
@segir187
Filter by algorithm tags last in filter_problems_by_query as it is po…
e78f6ee 
…ssibly the slowest way of filtering.
@segir187
aggregated_tag_label now redirects to filtering displaying tag
1a3b5bb 
proposals.
@segir187
Checkbox automatically checked if proposals included in http request.
858b247
@segir187
Tag label links keep checkbox state.
35daa3f
@segir187
Add TestTagProposalSearch.
4343d3b
@segir187
Change wording next to checkbox to better reflect dual function of th…
c24bca8 
…e checkbox.
@segir187 segir187 requested a review from twalen April 9, 2025 13:59
segir187 and others added 13 commits April 9, 2025 17:28
segir187 added 19 commits May 6, 2025 22:06
@segir187
Add options to assign tags to tasks.
7145508
@segir187
Remove unnecessary comments.
a909494
@segir187
Change create_through_records to use get_unique_candidate function.
8451058
@segir187
Move creation of proposals into separate function.
56c1f78
@segir187
Fix inconsistences across create_ functions.
648a1c8
@segir187
Better handling of errors.
4a4f236
@segir187
Add option to create difficulty tag proposals.
cbef3be
@segir187
Change remove_mass_generated_data.py to remove all records created wi…
0378ad4 
…th mass_create_tool.py.
@segir187
For DifficultyTagThrough, ensure each Problem is assigned at most one…
4163784 
… difficulty tag.
@segir187
Unify naming convention for created object list in create functions.
d57273f
@segir187
Change __str__ method of Through models to include the assigned tag.
2e4d2eb
@segir187
Add names to auto-generated problems.
3901e56
@segir187
Change auto prefix from auto_ to _auto_.
a56f4f1
@segir187
Remove unnecessary part of help in remove_mass_generated_data.py.
c28c60d
@segir187
Use the Problem.create() function for problem creation.
0731603
@segir187
Add create_problems function to handle creation of Problem objects al…
e5b993c 
…ong with objects of associated classes (so far just ProblemSite).
@segir187
Add info about cascade removal of problem sites.
9edc5bd
@segir187
Make sure the mock data creation tool only works when DEBUG=True.
c309c85
@segir187
Merge remove_mass_generated_data tool into mass_create_tool. Change
6b595e1 
argument types to unsigned_int.
@segir187
Copy link
Contributor Author

I did some benchmarking, these are my results:

The tag through and tag proposal records were randomly distributed.
For each data set I performed one hundred connection attempts using ApacheBench.
All of the testing was done with with one concurrent connection, as the default repo instance of oioioi runs on one thread by iirc.

The tool I used for generating the data will be merged in a different PR.

For data:

Model Problems Users AlgoTags AlgoTagThrough AlgoTagProposals
Amount 2 1 2 3 10

I got average times of:

Before After
134 ms 135 ms

For data:

Model Problems Users AlgoTags AlgoTagThrough AlgoTagProposals
Amount 1000 100 20 2000 12000

I got average times of:

Before After
182 ms 222 ms

For data:

Model Problems Users AlgoTags AlgoTagThrough AlgoTagProposals
Amount 12000 100 200 2000 12000

I got average times of:

Before After
350 ms 374 ms

It seems that the performance decrease I was worried about is negligible.

This was referenced May 20, 2025
Closed
Merged
@segir187 segir187 marked this pull request as ready for review May 20, 2025 17:45
@segir187 segir187 requested a review from MasloMaslane as a code owner May 20, 2025 17:45
twalen
twalen approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@twalen twalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@segir187 segir187 merged commit 1cde774 into sio2project:master May 21, 2025
1 check passed
@segir187 segir187 deleted the FilterByTagProposals branch May 21, 2025 14:54
wraczuk pushed a commit to wraczuk/oioioi that referenced this pull request May 21, 2025
@segir187
Filter by tag proposals (sio2project#503)
5a0c962 
* Add the option for filtering by algorithm tags to take into account most popular tag proposals when choosing which tasks to show in the results.

* Add the value `include_proposals` to be included in `?q=` for the problemset page controlling whether filtering by algorithm tags takes the most popular tag proposals into account.

* Add `TestTagProposalsSearch` test class for this feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twalen twalen twalen approved these changes

@MasloMaslane MasloMaslane Awaiting requested review from MasloMaslane MasloMaslane is a code owner

Assignees

@twalen twalen

@segir187 segir187

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bugfixes and changes to task filtering in probset Feature Request: Using proposed algorithm tags for filtering tasks.
2 participants
@segir187 @twalen